Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big images #321

Open
wants to merge 6 commits into
base: big_images
Choose a base branch
from
Open

Big images #321

wants to merge 6 commits into from

Conversation

B-LechCode
Copy link
Collaborator

@woelper: I finally implemented the tiling feature for the new approach.
Rendering the preview image now seems to be stable.
There's one downside: when the preview render consists of multiple textures, there's a small gap between the textures. I don't know why. I'd like to draw that via notan, too as this didn't have this problem for rendering the main image. But I don't know how to add a "draw" to the render pipeline at that point.

Could you help me with that, please?

After making it all work, I will refactor this and do some safety stuff - after that I will bring up a PR for master :)

@B-LechCode B-LechCode requested a review from woelper May 10, 2024 09:24
@woelper
Copy link
Owner

woelper commented May 28, 2024

Sorry, I have not forgotten this. It is just hard to find the time this deserves!

I hope I can help with the info window, but I've seen that egui renders the texture differently than notan. I am unsure if we can reuse the rendering code there as well, maybe this requires some creative problem solving! :)

@B-LechCode
Copy link
Collaborator Author

Sorry, I have not forgotten this. It is just hard to find the time this deserves!

I hope I can help with the info window, but I've seen that egui renders the texture differently than notan. I am unsure if we can reuse the rendering code there as well, maybe this requires some creative problem solving! :)

I chatted back to my boss, I will try to get an interesing example image out of our line scan system.
The latest commits are at least "okay" from that perspective - there is a small margin between tiles, but if you imagine textures of 16k by 16k, they won't show up frequently.
Please have a look - if you're okay with it, I will start cleaning the code up. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants