Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show skip reason by default #941

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

chirizxc
Copy link
Contributor

/closes #940

@henryiii
Copy link
Collaborator

I don't know if this needs to be a flag. I think something like this would likely be fine:

-        result.log(f"* {name}: {status}")
+        if result.status is Status.SKIPPED and result.reason:
+            result.log(f"* {name}: {status} ({result.reason})")
+        else:
+            result.log(f"* {name}: {status}")

@chirizxc
Copy link
Contributor Author

chirizxc commented Mar 25, 2025

I don't know if this needs to be a flag. I think something like this would likely be fine:

-        result.log(f"* {name}: {status}")
+        if result.status is Status.SKIPPED and result.reason:
+            result.log(f"* {name}: {status} ({result.reason})")
+        else:
+            result.log(f"* {name}: {status}")

maybe we can make this behaviour by default?

@henryiii
Copy link
Collaborator

That's what I meant. If a reason is set, we could just always show it.

@chirizxc chirizxc changed the title feat: add --skip-summary-details flag feat: show skip reason by default Mar 25, 2025
@chirizxc
Copy link
Contributor Author

idk why coverage failed, but here is successful: https://github.com/chirizxc/nox/actions/runs/14065702085/job/39389829080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add option to display reason for skipped sessions in the summary
2 participants