-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show skip reason by default #941
base: main
Are you sure you want to change the base?
Conversation
I don't know if this needs to be a flag. I think something like this would likely be fine: - result.log(f"* {name}: {status}")
+ if result.status is Status.SKIPPED and result.reason:
+ result.log(f"* {name}: {status} ({result.reason})")
+ else:
+ result.log(f"* {name}: {status}") |
maybe we can make this behaviour by default? |
That's what I meant. If a reason is set, we could just always show it. |
idk why coverage failed, but here is successful: https://github.com/chirizxc/nox/actions/runs/14065702085/job/39389829080 |
/closes #940