Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jobs): Add wrapper job to start QueryService rebuild #1371

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tarrow
Copy link
Contributor

@tarrow tarrow commented Jan 19, 2024

No description provided.

@m90
Copy link
Contributor

m90 commented Jan 22, 2024

Not sure if this should part of this script, but there is one thing missing: in certain scenarios, whoever runs this script might want to delete all jobs that exist in the qs-jobs namespace as otherwise we'd just apply a spec that is already there and might also already have been finished. I.e.: jobs inserted that way are not guaranteed to run unless we a. clean the namespace or b. change the naming mechanism (right now, the job name is a hash of wiki domain + entity ids for that job)

@tarrow
Copy link
Contributor Author

tarrow commented Jan 29, 2024

I feel like this script could perhaps warn if the namespace is not empty and ask for confirmation to continue explaining that this is the case?

@m90
Copy link
Contributor

m90 commented Jan 29, 2024

I feel like this script could perhaps warn if the namespace is not empty and ask for confirmation to continue explaining that this is the case?

Sounds reasonable, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants