Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked] Extend the address_pages AB test end date #3026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moiikana
Copy link
Contributor

  • the test_02 bucket (ap=1) is still used in the last banners from 2024, so we still want to be able to navigate to the different buckets with an URL parameter. For that the end date had to be adjusted.

- the `test_02` bucket (ap=1) is still used in the last banners from 2024, so we still want to
be able to navigate to the different buckets with an URL parameter.
For that the end date had to be adjusted.
@gbirke gbirke changed the title Prolong the address_pages AB test Extend the address_pages AB test end date Feb 4, 2025
@@ -53,7 +53,7 @@ campaigns:
description: Test different iterations of address pages
reference: "https://phabricator.wikimedia.org/T366576"
start: "2024-07-01"
end: "2024-12-31"
end: "2030-12-31"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving it another 5 years makes this more of a feature than an A/B test. I'd like to have a discussion with the PM if there are really "tests" going on around this, that might conclude at some point (where we will remove the <FeatureToggle> tags and the duplicated address forms from the frontend) or if they consider the 2 address forms now a "feature" of the fundraising application. In the latter case we'd need a bit of refactoring to make the fundraising application act on the ap parameter without the A/B test campaigns. This is to avoid "feature toggle creep" and give the feature explicitly named code for better readability and visibility instead of having to guess and look up what the feature toogle ID means and getting pointed to 2023/2024 banner tickets

@moiikana
Copy link
Contributor Author

moiikana commented Feb 4, 2025

I'd like to have a discussion with the PM

I created a ticket: https://phabricator.wikimedia.org/T385562

@moiikana moiikana changed the title Extend the address_pages AB test end date [Blocked] Extend the address_pages AB test end date Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants