Fix NullPointerException in NavigationModule #7815
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing a crash that affects ~1% of our user base per month, that's caused by:
After looking into the code, we realised that that the null check and
.isFinishing()
are not referencing the same activity.Here's a screenshot with stack trace from Sentry:
![Screenshot 2023-11-20 at 14 38 24](https://private-user-images.githubusercontent.com/8324312/284283296-231ddbdd-d962-46e5-abea-b45eda66b81d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjU3MTgsIm5iZiI6MTcxOTYyNTQxOCwicGF0aCI6Ii84MzI0MzEyLzI4NDI4MzI5Ni0yMzFkZGJkZC1kOTYyLTQ2ZTUtYWJlYS1iNDVlZGE2NmI4MWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjlUMDE0MzM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Yzc3Mjc3YmJiMThjODk4ZWNkZmExNjYwMjc4ODI1NjhjNGJmYzBjY2MyYjI4NGQ5ZDY0ZjBmYWYxYTFmM2ViZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MZ_RzGUynJ464sIcXeIUIbPyjHNbMETOlS0ivzMFg5c)