feat(multi selector): implement multi selector support #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemni8
force-pushed
the
multi-selector-validation
branch
from
897986c to
d5dc1f9
Compare
nemni8
force-pushed
the
multi-selector-validation
branch
from
d5dc1f9 to
94d8c59
Compare
nemni8
force-pushed
the
multi-selector-validation
branch
from
94d8c59 to
7b4e699
Compare
tombenezra
requested changes
Feb 28, 2021
| return services.find( | ||
| service => | ||
| service.name === $W && | ||
| !Object.prototype.hasOwnProperty.call(service, "memberOf") |
There was a problem hiding this comment.
service.hasOwnProperty("memberOf")
|
|
||
| const QUERYABLE_TYPE = "TypeNameToSdkType"; | ||
| const $W = "$w"; | ||
| const $W_MEMBERS_KEY = "/** $W_NAMESPACE_MEMBERS */"; |
There was a problem hiding this comment.
mask with hashtags or similar
| const queryableType = getQueryableObjectType(services); | ||
|
|
||
| const page$w = fs.readFileSync("./src_types/pages/$w.d.ts", null, "utf-8"); | ||
| let page$w = fs.readFileSync("./src_types/pages/$w.d.ts", "utf-8"); | ||
| page$w = page$w.replace($W_MEMBERS_KEY, $wMembers); |
There was a problem hiding this comment.
assign to different variables
| type OnlyVaildSelectorsChars<S> = | ||
| S extends "" | ||
| ? unknown | ||
| : S extends `${VaildSelectorsChars}${infer Tail}` |
There was a problem hiding this comment.
make sure selectors are separated with comma, and not every legal char
There was a problem hiding this comment.
Button #button1, #button2 ==> true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.