Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ranking empty inputs #415

Merged
merged 10 commits into from
Jan 23, 2025
Merged

fix: ranking empty inputs #415

merged 10 commits into from
Jan 23, 2025

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jan 8, 2025 •
edited
Loading

Description of change

  • fix: ranking empty inputs
  • fix: adapt to breaking llama.cpp changes

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto January 8, 2025 18:53
@giladgd giladgd self-assigned this Jan 8, 2025
@giladgd giladgd merged commit 86e1bee into master Jan 23, 2025
18 checks passed
@giladgd giladgd deleted the gilad/fixRerankingEmptyInput branch January 23, 2025 03:05
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xdevalias 0xdevalias mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ido-pluto ido-pluto Awaiting requested review from ido-pluto

Assignees

@giladgd giladgd

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@giladgd