Fix: Project defined routes are prioritized over internal and external routes in dev

[joshmkennedy]

Changes

This PR is an attempt to fix #13091.

I added a rule to the routeComparator function that ensures project defined routes will be sorted before internal or external routes.

Testing

I added a test that checks that the dynamic routes are sorted before the static internal 404 route.

Docs

This shouldn't affect a user's behavior, as creating /404.astro was already prioritized.

[changeset-bot]

🦋 Changeset detected

Latest commit: 36885a0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #13117 will not alter performance

_{Comparing joshmkennedy:fix-dynamic-404-route (36885a0) with main (2a85bd7)}

Summary

✅ 6 untouched benchmarks

[ematipico]

The user reported that the issue occurs in dev only, so the fix should be in the vite dev server plugin

[joshmkennedy]

This may not be the fix, as this is affecting services like islands and images. I'll look to add a fix that affects just the default 404 route.