Support scope styles for picture element in Picture component #10975
Conversation
🦋 Changeset detectedLatest commit: 9b012c4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
There was a problem hiding this comment.
I am not sure this solution will be future-proof, especially if in the future we will land withastro/roadmap#243
However, I don't know if there's a better solution, so I leave the final call to you
| } | ||
| } | ||
| for (const key in props) { | ||
| if (key.startsWith('data-astro-cid')) { |
|
Yeah if we want to support the feature request and not break this, we would probably need to support some kind of I don't think this is perfect too, but I think it enables a nice usecase and we could try to revisit this again. I'll take the approvals as a green light though 😄 |
Changes
fix #10307
The PR uses some tricks to get the scoped attributes or class to pass it to the
<picture>element, instead of only to theimgelement.The trick uses regexes for
astro-*class anddata-astro-cid-*attributes, which perhaps is not the most elegant, but I think it should be fine?Question: Do we want to check for
data-astro-cidspecifically?Testing
Added test
Docs
Added changeset