-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating additional values #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rliskunov thanks for your PR. A few things here:
- please remove the
.gitignore
file as it is specific to your local setup but nothelm
related - please keep correct and indentation, ideally we want to keep the original indentation
- for your templating issue, please elaborate more about what you are trying to achieve? As most of the YAML templates were generated from
helm create
command. It would be cleaner to keep the original unless there is a real necessity.
When this solution can be fully merged? |
@rliskunov @gitkent - can we prioritize this fix for the next version by merge it please? |
@matera-dgr @gitkent sorry it took so long. I made the final edits. Take a look at this, please. |
@gitkent May you please review and approve the pull request so it will be able to be merged for the next release? |
@rliskunov please take a look into the CI build is failing. Thanks |
@gitkent bumped a version. I need your approve |
I'm using additional variables inside
values.yaml
.For example,
domain: {{ .Chart.Name }}.{{ .Values.ingress.stage }}
and I add it toingress.hosts[0].{{ domain }}
.However, the values are not substituted after templating. This is due to the lack of a call to the
tpl
function. This Pull Request is designed to solve this problemAdditionally, I put
.gitignore
to exclude unused files from the repository.References
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java