Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating additional values #32

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Templating additional values #32

merged 5 commits into from
Mar 27, 2025

Conversation

rliskunov
Copy link
Contributor

I'm using additional variables inside values.yaml.

For example, domain: {{ .Chart.Name }}.{{ .Values.ingress.stage }} and I add it to ingress.hosts[0].{{ domain }}.

However, the values are not substituted after templating. This is due to the lack of a call to the tpl function. This Pull Request is designed to solve this problem

Additionally, I put .gitignore to exclude unused files from the repository.

References

  • Personal problem in my pet project

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@rliskunov rliskunov requested a review from gitkent as a code owner February 25, 2024 14:43
Copy link
Collaborator

@gitkent gitkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rliskunov thanks for your PR. A few things here:

  • please remove the .gitignore file as it is specific to your local setup but not helm related
  • please keep correct and indentation, ideally we want to keep the original indentation
  • for your templating issue, please elaborate more about what you are trying to achieve? As most of the YAML templates were generated from helm create command. It would be cleaner to keep the original unless there is a real necessity.

@oranerez
Copy link

When this solution can be fully merged?
I need it for my deployment with custom ingress host variables value.
Thank you.

@oranerez
Copy link

@rliskunov @gitkent - can we prioritize this fix for the next version by merge it please?

@rliskunov
Copy link
Contributor Author

@matera-dgr @gitkent sorry it took so long. I made the final edits. Take a look at this, please.

@rliskunov rliskunov requested a review from gitkent March 19, 2025 16:37
@oranerez
Copy link

@gitkent May you please review and approve the pull request so it will be able to be merged for the next release?
Thank you.

@gitkent
Copy link
Collaborator

gitkent commented Mar 27, 2025

@matera-dgr @gitkent sorry it took so long. I made the final edits. Take a look at this, please.

@rliskunov please take a look into the CI build is failing. Thanks

@rliskunov
Copy link
Contributor Author

@gitkent bumped a version. I need your approve

@gitkent gitkent merged commit f4d20ab into wiremock:master Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants