Wpb 17321 enable demo cd #828
Conversation
sghosh23
left a comment
sghosh23
left a comment
There was a problem hiding this comment.
The PR looks good to me, have some clarification questions and some suggestions.
May be adding a tag based workflow not to deploy the demo on every commit/PR would be helpful.
offline/cd_demo.sh
Outdated
| yq eval -i ".wiab.hosts.deploy_node.ansible_ssh_private_key_file = \"${INVENTORY_DIR}/ssh_private_key\"" "${INVENTORY_FILE}" | ||
| yq eval -i ".wiab.vars.artifact_hash = \"$COMMIT_HASH\"" "${INVENTORY_FILE}" | ||
| yq eval -i ".wiab.hosts.deploy_node.ansible_user = \"$TEST_USER\"" "${INVENTORY_FILE}" | ||
| cat "${INVENTORY_DIR}/ssh_private_key" |
There was a problem hiding this comment.
Is it intentional to print private_key, I would assume it was for test purpose
There was a problem hiding this comment.
yes, let me remove it
| # A new WIAB (wire in a box) dev solution has been created https://docs.wire.com/latest/how-to/install/demo-wiab.html and can be used until this (wiab-staging) gets updated | ||
| name: Deploy on Hetzner WIAB setup | ||
| on: | ||
| workflow_run: |
There was a problem hiding this comment.
The workflow has nothing here. Should this file be part of the PR?
There was a problem hiding this comment.
The comment is meant to highlight that there was an old solution which is not to be confused with current wiab-demo.
| @@ -1,3 +1,5 @@ | |||
| # This playbook is not-up-to-date, requires to be updated to match with current developments | |||
| # A new WIAB (wire in a box) dev solution has been created https://docs.wire.com/latest/how-to/install/demo-wiab.html and can be used until this (wiab-staging) gets updated | |||
There was a problem hiding this comment.
Please elaborate the comments, is it relevant to this PR and update?
There was a problem hiding this comment.
Earlier we used to have a Wire in a box (staging) environment and we used to use this playbook to deploy it. Now we have another wiab (demo/dev) environment and this comment is to say that, we haven't updated the other wiab(staging) solution yet, so users can use the wiab-demo in the meantime.
|
|
||
| # shellcheck disable=SC2087 | ||
|
|
||
| # This script can be replaced with a simpler solution of wiab-demo installtion |
There was a problem hiding this comment.
Comments? If the script needs to be touched in another PR mention that please. Just comments is a bit confusing here
There was a problem hiding this comment.
this PR is trying to remove the confusion between old wiab staging and current wiab-demo one
| @@ -0,0 +1,2 @@ | |||
| Added: enable cd-demo.sh to verify the demo-wiab builds | |||
There was a problem hiding this comment.
Is it verifying or running an actual deployment?
There was a problem hiding this comment.
it will verify the changes for wiab-demo via deploying it
There was a problem hiding this comment.
I would rephrase it as Added: cd-demo.sh to deploy and verify the demo-wiab builds
|
Change type
Basic information
Testing
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case