Skip to content

feat(new-registration): new registration personal account creation (WPB-17454) #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Jun 16, 2025
Merged

feat(new-registration): new registration personal account creation (WPB-17454) #4060

merged 48 commits into from
Jun 16, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 11, 2025 •
edited by github-actions bot
Loading

StoryWPB-17454 [Android] New Registrations Flows - Personal account creation flow

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to implement new registration flows.

Solutions

The plan is as follows:

  1. Reuse and duplicate when we can't reuse, so we take advantage of the previous/current flow for account creation.
  2. We merge into develop, and we keep both flows, since the new flow is available under a feature flag.
  3. After green light and QA'ed, we will remove the code for the old flows, basically all the code under
  • com.wire.android.ui.authentication.create.code
  • com.wire.android.ui.authentication.create.details
  • com.wire.android.ui.authentication.create.email
  • com.wire.android.ui.authentication.create.overview
  • com.wire.android.ui.authentication.create.summary

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Use an internal build, create a personal account and follow the flow. The designs are changed and the flow is simplified in terms of parameters and less screens.

Attachments (Optional)

Screen.Recording.2025-06-11.at.16.45.15.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

yamilmedina added 30 commits June 3, 2025 11:14
@yamilmedina
new reg
c61631f
@yamilmedina
Merge branch 'develop' into feat/new-regs-accountselector
c6eb8ac
@yamilmedina
local FF for selector screen vs old flow
d38bfd9
@yamilmedina
flavor based FF for selector screen vs old flow
03bff85
@yamilmedina
wip
e4d4dad
@yamilmedina
selector components and actions
45778a8
@yamilmedina
refactor component naming for reusage
7802ad4
@yamilmedina
navigation to current native flows
edf322f
@yamilmedina
selector components and actions
fe1a8e3
@yamilmedina
detekt
a50dfec
@yamilmedina
detekt
d786602
@yamilmedina
Merge branch 'develop' into feat/new-regs-accountselector
5a6846f
@yamilmedina
change path
9544062
@yamilmedina
wip for details, new navigation graph and pass email through
6174622
@yamilmedina
add deprecation notice for old routes
1e697e4
@yamilmedina
feat: changes for personal account, merging into one vm
4daba9b
@yamilmedina
feat: changes for personal account, merging into one vm
6c8b56f
@yamilmedina
feat: changes for personal account, merging into one vm
05818ba
@yamilmedina
feat: changes for personal account, merging into one vm
23ff4a9
@yamilmedina
feat: changes for personal account, merging into one vm
2be20f3
@yamilmedina
Merge branch 'develop' into feat/new-regs-accountselector
31b4cad
@yamilmedina
Merge branch 'feat/new-regs-accountselector' into feat/new-regs-perso…
945d0c8 
…nalacc
@yamilmedina
feat: pr comments
d9c6876
@yamilmedina
Merge branch 'feat/new-regs-accountselector' into feat/new-regs-perso…
ab63bb4 
…nalacc
@yamilmedina
wip, simplyfing and removing not needed code in new flow
27f16ff
@yamilmedina
Merge branch 'develop' into feat/new-regs-personalacc
4deb116
@yamilmedina
apply designs and navigation to verification code
e2cc592
@yamilmedina
feat: integrate with usecase
8e00d5e
@yamilmedina
feat: implement new design to username
1c19899
@yamilmedina
feat: implement new design to username
461b460
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4060.apk is available for download

@yamilmedina yamilmedina mentioned this pull request Jun 12, 2025
Merged
7 tasks
saleniuk
saleniuk approved these changes Jun 12, 2025
View reviewed changes
...src/main/kotlin/com/wire/android/ui/registration/code/CreateAccountVerificationCodeScreen.kt
stringResource(id = R.string.create_account_code_error_title),
stringResource(id = R.string.create_account_code_error_personal_account_creation_restricted)
)
// TODO: sync with design about the error message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, looks like we forgot to sync with design for over 3 years 🤭

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4060.apk is available for download

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@yamilmedina yamilmedina enabled auto-merge June 16, 2025 13:56
@yamilmedina yamilmedina added this pull request to the merge queue Jun 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4060.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4060.apk is available for download

Merged via the queue into develop with commit 5543237 Jun 16, 2025
12 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/new-regs-personalacc branch June 16, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@yamilmedina yamilmedina

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamilmedina @Garzas @saleniuk