-
Notifications
You must be signed in to change notification settings - Fork 39
refactor: rename ConversationOptions to CreateConversationParam #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
refactor: rename ConversationOptions to CreateConversationParam #4032
Conversation
… NewConversationViewModel and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just actions are failing probably because the import wasn't updated as well
…-CreateConversationParam
…pdate related usages
…-CreateConversationParam
…pdate related usages
…-CreateConversationParam # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModel.kt # kalium
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4032 +/- ##
========================================
Coverage 47.83% 47.83%
========================================
Files 499 499
Lines 17443 17443
Branches 2859 2859
========================================
Hits 8344 8344
Misses 8240 8240
Partials 859 859
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
it was just a TODO in the code to do this rename
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.