fix: fetch MLS public keys the same way as feature config [WPB-17161] #3991
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…droid [WPB-11304] (#3935) Co-authored-by: yamilmedina <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
This reverts commit 5c4e3d8.
(cherry picked from commit 542f53c)
…into fix/fetch-mls-public-keys-on-foreground # Conflicts: # kalium
saleniuk
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3991 +/- ##
========================================
Coverage 47.51% 47.52%
========================================
Files 503 503
Lines 17652 17654 +2
Branches 2917 2917
========================================
+ Hits 8388 8390 +2
Misses 8384 8384
Partials 880 880
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Built wire-android-staging-compat-pr-3991.apk is available for download |
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
…ic-keys-on-foreground # Conflicts: # .github/workflows/build-prod-app.yml # app/src/main/kotlin/com/wire/android/di/accountScoped/DebugModule.kt # app/src/main/kotlin/com/wire/android/ui/authentication/devices/register/RegisterDeviceScreen.kt # app/src/main/kotlin/com/wire/android/ui/authentication/login/email/LoginEmailViewModel.kt # app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt # app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptionsViewModel.kt # app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt # app/src/main/kotlin/com/wire/android/ui/home/HomeState.kt # app/src/main/kotlin/com/wire/android/ui/home/HomeViewModel.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/media/ConversationMediaScreen.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/ConversationMessagesViewModel.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/MessageContentAndStatus.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/audio/AudioMessageType.kt # app/src/main/play/release-notes/en-US/default.txt # app/src/test/kotlin/com/wire/android/ui/authentication/login/email/LoginEmailViewModelTest.kt # app/src/test/kotlin/com/wire/android/ui/calling/SharedCallingViewModelTest.kt # app/src/test/kotlin/com/wire/android/ui/home/AppSyncViewModelTest.kt # app/src/test/kotlin/com/wire/android/ui/home/HomeViewModelTest.kt # app/src/test/kotlin/com/wire/android/ui/home/conversations/messages/ConversationMessagesViewModelTest.kt # app/src/test/kotlin/com/wire/android/ui/settings/debug/DebugDataOptionsViewModelTest.kt # build-logic/plugins/src/main/kotlin/AndroidCoordinates.kt # kalium
…ic-keys-on-foreground # Conflicts: # kalium
|
|
|
|
Built wire-android-staging-compat-pr-3991.apk is available for download |
|
Built wire-android-dev-debug-pr-3991.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Fetching MLS public keys should be treated the same way as feature-configs.
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/160858877/Feature+flags+and+feature+configuration#Periodic-fetch-of-configuration
Solutions
Add fetching MLS public keys to the
AppSyncViewModel. Update kalium version to the one with MLS public keys changes to be able to useMLSPublicKeysSyncWorker(it executes fetch every 24h as well).Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.