Skip to content

Conversation

@jaxwilko
Copy link
Member

This PR adds additional options to existing commands and adds additional commands.

It's a merge of the functionality added in the storm extension here: wintercms/storm#197

Note

For the search command I've added a returnArray option, I don't remember why exsactly, but I believe some information was returned by composer but lost when cast to custom objects. Not 100% sure it's even still in use in the Winter PR so maybe worth removing (i'll review with fresh eyes in the coming days).

However, it maybe nice to have a more consistant method for returning the raw data from composer, thoughts?

@jaxwilko jaxwilko requested a review from bennothommo as a code owner March 12, 2025 22:45
Copy link
Member

@bennothommo bennothommo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bennothommo
Copy link
Member

I agree that there should be a command to return the raw Composer response. Ideally, the raw response should be stored in the Command instance and be accessible through a method, so the likely candidate for this would be the Command abstract. Worth pursuing in another PR.

Copy link
Member

@bennothommo bennothommo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, scratch the previous approval, will need to either update the tests or make sure they pass :)

@jaxwilko
Copy link
Member Author

I agree that there should be a command to return the raw Composer response. Ideally, the raw response should be stored in the Command instance and be accessible through a method, so the likely candidate for this would be the Command abstract. Worth pursuing in another PR.

Yeah i think that would be perfect, i'll do a little tinkering and see if i can provide a consitant getOutput() or something :)

@LukeTowers LukeTowers requested a review from bennothommo July 28, 2025 05:59
@bennothommo bennothommo merged commit 8d6f0fb into main Jul 28, 2025
4 checks passed
@bennothommo bennothommo deleted the wip/extra-features branch July 28, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants