Merge "Re-enable Phan and fix warnings for internal-serialization"

wikimedia · Mar 3, 2025 · ff24f07 · ff24f07
2 parents 445d764 + da9d84d
commit ff24f07
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/.phan/config.php b/.phan/config.php
@@ -65,7 +65,6 @@
 $cfg['exclude_analysis_directory_list'] = array_merge(
 	$cfg['exclude_analysis_directory_list'],
 	[
-		'lib/packages/wikibase/internal-serialization/src/',
 		'../../extensions/Babel/',
 		'../../extensions/CirrusSearch/',
 		'../../extensions/Echo/',

diff --git a/...kages/wikibase/internal-serialization/src/Deserializers/LegacyFingerprintDeserializer.php b/...kages/wikibase/internal-serialization/src/Deserializers/LegacyFingerprintDeserializer.php
@@ -6,7 +6,6 @@
 use Deserializers\Exceptions\DeserializationException;
 use Deserializers\Exceptions\InvalidAttributeException;
 use InvalidArgumentException;
-use Wikibase\DataModel\Entity\Item;
 use Wikibase\DataModel\Term\AliasGroup;
 use Wikibase\DataModel\Term\AliasGroupList;
 use Wikibase\DataModel\Term\Fingerprint;
@@ -23,7 +22,7 @@ class LegacyFingerprintDeserializer implements Deserializer {
 	/**
 	 * @param array $serialization
 	 *
-	 * @return Item
+	 * @return Fingerprint
 	 * @throws DeserializationException
 	 */
 	public function deserialize( $serialization ) {

diff --git a/...ages/wikibase/internal-serialization/src/Deserializers/LegacySiteLinkListDeserializer.php b/...ages/wikibase/internal-serialization/src/Deserializers/LegacySiteLinkListDeserializer.php
@@ -19,7 +19,7 @@ class LegacySiteLinkListDeserializer implements Deserializer {
 	/**
 	 * @param array $serialization
 	 *
-	 * @return SiteLink[]
+	 * @return SiteLinkList
 	 * @throws DeserializationException
 	 */
 	public function deserialize( $serialization ) {

diff --git a/lib/packages/wikibase/internal-serialization/src/LegacyDeserializerFactory.php b/lib/packages/wikibase/internal-serialization/src/LegacyDeserializerFactory.php
@@ -51,7 +51,7 @@ public function newEntityDeserializer() {
 	}
 
 	/**
-	 * @return Deserializer
+	 * @return DispatchableDeserializer
 	 */
 	private function newItemDeserializer() {
 		return new LegacyItemDeserializer(
@@ -63,7 +63,7 @@ private function newItemDeserializer() {
 	}
 
 	/**
-	 * @return Deserializer
+	 * @return DispatchableDeserializer
 	 */
 	private function newPropertyDeserializer() {
 		return new LegacyPropertyDeserializer(