Refactor preview list fetch mechanism #4501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the logic to fetch preview reading list to a dedicated repository instead of a helper function. This is a small portion for carrying out major refactoring tasks for T303935
cooltey
reviewed
Mar 25, 2024
| ) { | ||
|
|
||
| suspend fun getPreviewReadingList(): ReadingList? { | ||
| val encodedJson = prefs.receiveReadingListsData |
There was a problem hiding this comment.
It would be great if use Prefs.receiveReadingListsData directly.
There was a problem hiding this comment.
I've converted it to a variable so as to support constructor injection (and easily write tests later with mocks). What do you think?
…nto preview_reading_list_refactor
|
Hi, would it be possible to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logic to fetch preview reading list to a dedicated repository instead of a helper function. This is a small portion for carrying out major refactoring tasks for T303935