CI: Test against Python 3.10 #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Comment on lines
+29
to
+34
| - ipywidgets: "7.8" | ||
| voila: "0.3.7" | ||
| python-version: "3.10" | ||
| - ipywidgets: "8.1" | ||
| voila: "0.5.4" | ||
| python-version: "3.10" |
There was a problem hiding this comment.
Note that we use a ~ for the installation, so this change is not needed.
There was a problem hiding this comment.
Ah, I see that you have changed the matrix from 2x2 to 1x2. I think ipywidsgets should be kept top level for the matrix to work.
Also update ipywidgets to the latest minor versions (7.8 and 8.1 respectively)
maartenbreddels
force-pushed
the
python-3.10-ci
branch
from
bf9fbeb
to
de7ad04
Compare
maartenbreddels
force-pushed
the
master
branch
4 times, most recently
from
2446983
to
0d6161d
Compare
iisakkirotko
force-pushed
the
master
branch
2 times, most recently
from
c2951b9
to
8816e36
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
240a079
to
b098da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bits of maintenance on the CI:
Testing against a more modern Python version ensures it not only works on that version, but also gives warnings about potential incompatibilities with future Python versions. Since some packages are already dropping support for Python 3.9 and older (see SPEC 0), testing at least against Python 3.10 is recommended.
Testing against Python 3.11 and Python 3.12 is currently blocked by Vaex not supporting those versions, see vaexio/vaex#2331. I don't know exactly what Vaex is used for in Solara, but it could be worth considering removing it as a dependency.