Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add-on upload more robust against long processing times and show better error messages #6437

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bunnybot
Copy link

NordfrieseMirrored from Codeberg
Created on Tue Apr 23 20:39:53 CEST 2024 by Benedikt Straub (Nordfriese)


Type of change
Bugfix

Issue(s) closed
Fixes https://codeberg.org/wl/wl_addons_server/issues/87

New behavior

  • Extend the existing fix for clearing the send buffer to work with the very big add-on Europeans Tribe v4.4.0
  • Better error messages when something fails in the add-ons network I/O

Additional context
I tested this by uploading Europeans Tribe 4.4.0 to the alpha server. @MarkMcWire please check if this allows you to upload the add-on again as well.

@bunnybot bunnybot added this to the v1.3 milestone Apr 23, 2024
@bunnybot bunnybot self-assigned this Apr 23, 2024
@bunnybot
Copy link
Author

Assigned to Nordfriese

@bunnybot bunnybot added bug Something isn't working multiplayer & networking Internet & LAN gaming features, networking backend addon Problems and requests related to add-ons ci:success CI checks succeeded labels Apr 23, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 1, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 1, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 14, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 16, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon Problems and requests related to add-ons bug Something isn't working ci:success CI checks succeeded multiplayer & networking Internet & LAN gaming features, networking backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants