Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add-Ons Website Maps Integration #6329

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

bunnybot
Copy link

@bunnybot bunnybot commented Jan 28, 2024

NordfrieseMirrored from Codeberg
Created on Sun Jan 28 19:37:38 CET 2024 by Benedikt Straub (Nordfriese)


Type of change
New feature (for v1.3)

Counterpart to https://codeberg.org/wl/wl_addons_server/pulls/84

How it works
The add-ons server now provides info about website maps. The client displays maps usefully with some map-specific filtering options and allows one-click installing and uninstalling.

For testing, the server-side counterpart is currently served on Alpha:

--addons_server_port=7377

Not yet implemented are:

  • Translations for website maps
  • Commenting, voting, and download counter. You can view comments and votes like for add-ons (except for relationships between comment threads), but creating and editing them is not yet possible due to server-side database complications.

Possible regressions
All add-ons networking

Screenshots
grafik

@bunnybot bunnybot added this to the v1.3 milestone Jan 28, 2024
@bunnybot bunnybot changed the title WIP: Add-Ons Website Maps Integration Add-Ons Website Maps Integration Jan 28, 2024
@bunnybot bunnybot self-assigned this Jan 28, 2024
@bunnybot
Copy link
Author

Assigned to Nordfriese

@bunnybot bunnybot added enhancement New feature or request addon Problems and requests related to add-ons labels Jan 28, 2024
@bunnybot bunnybot changed the title Add-Ons Website Maps Integration WIP: Add-Ons Website Maps Integration Feb 11, 2024
@bunnybot
Copy link
Author

frankystoneMirrored from Codeberg
On Wed Feb 28 09:16:09 CET 2024, frankystone wrote:


It's a bit unclear where a downloaded map can be found:

  1. Mapsets as addons are shown as they were in maps/ (didn't there was an additional entry Add-On maps in the file selection screen some time ago?)
  2. Maps downloaded with this are installed in maps/Downloaded and shown in folder Downloaded Maps

At least there should be a hint after downloading. Something like "You can find this map in 'Downloaded Maps'".

On the long run there might be a need to do a rework of the file selection menu. E.g. don't sort sort by number of players by default, instead sort by date should be the default (optionally) so that just installed maps appear prior all others. Probably a fresh installed map is wanted to be played immediately without the need to search it in the maps list.

@bunnybot bunnybot added the ci:fail CI checks failed label Apr 2, 2024
@bunnybot bunnybot added ci:fail CI checks failed ci:success CI checks succeeded and removed ci:fail CI checks failed labels Apr 4, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Apr 4, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Apr 12, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Apr 22, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 1, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 4, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 17, 2024
@bunnybot bunnybot added ci:fail CI checks failed and removed ci:success CI checks succeeded labels May 21, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:fail CI checks failed labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon Problems and requests related to add-ons ci:success CI checks succeeded enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants