Testsuite skip irrelevant testruns #6314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can not be tested.
Because the tests can not check those.
Because coming tests use this map.
bunnybot
reviewed
Jan 15, 2024
There was a problem hiding this comment.
On Mon Jan 15 13:53:49 CET 2024, Tóth András (tothxa) commented.
| # ignore some subdirectories | ||
| - 'data/!(campaigns|maps|music|sound|tribes|world)/**' | ||
| # but track parts of them | ||
| - 'data/tribes/**.lua' # track lua files |
There was a problem hiding this comment.
On Mon Jan 15 13:53:50 CET 2024, Tóth András (tothxa) wrote:
This is not right. We must test new images too.
bunnybot
added
enhancement
utils/validate_github_workflow.py would have seen this.
Because coming tests use these maps.
bunnybot
added
ci:success
bunnybot
added
ci:success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Enhancement of testsuite
Issue(s) closed
Enhances #5880
New behavior
The job testsuite is skipped for changes in irrelevant directories.
How it works
For the list of dorny/paths-filter, it uses general excludes for some subdirectories. Some files inside are explicitly included after.
Possible regressions
I do not think I excluded too much, but I might have.
Additional context
Add any other context about the problem here.