Show a loader for running migrations #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka8725
requested changes
Jul 21, 2024
| @@ -2,7 +2,9 @@ | |||
| <html> | |||
| <head> | |||
| <title>Migrations</title> | |||
| <%= stylesheet_link_tag 'actual_db_schema/styles', media: 'all' %> | |||
| <%= csrf_meta_tags %> | |||
There was a problem hiding this comment.
What's the point in using csrf_meta_tags here? Do we really need it taking into account that these forms will be used only in development mode?
| const migrationActions = document.querySelectorAll('.migration-action'); | ||
|
|
||
| migrationActions.forEach(button => { | ||
| button.addEventListener('click', function (event) { |
There was a problem hiding this comment.
Will the web server support multiple requests? Always? Consider the web server is configured to serve only one request at a time. How will it behave if the user clicks to run one migration and clicks another one without waiting for its response? Is it an acceptable solution to disable just the pressed button then?
ka8725
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79