Skip to content

[WIP] Add variant support#1

Closed
hcho3 wants to merge 2 commits intowheelnext:masterfrom
hcho3:add_variant
Closed

[WIP] Add variant support#1
hcho3 wants to merge 2 commits intowheelnext:masterfrom
hcho3:add_variant

Conversation

@hcho3
Copy link
Copy Markdown

@hcho3 hcho3 commented Jul 21, 2025

No description provided.

@@ -103,6 +128,13 @@ def build(app: Application, location, targets, hooks_only, no_hooks, ext, clean,
)
else:
command = ['python', '-u', '-m', 'hatchling', 'build', '--target', target]
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing, you may want to replace python with /workspace/.venv/bin/python, to use the updated version of Hatchling.

Copy link
Copy Markdown

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you probably need a PEP517 config_settings interface too. It is quite common to build hatchling packages via python -m build.

@hcho3
Copy link
Copy Markdown
Author

hcho3 commented Sep 15, 2025

Continued in pypa#2037

@hcho3 hcho3 closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants