Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Date & time generators #161

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Qqwy
Copy link
Contributor

@Qqwy Qqwy commented Dec 30, 2021

Implementation of #129

  • Date generator
    • Tests
  • Time generator
    • Tests
  • DateTime generator
    • Tests
  • NaiveDateTime generator
    • Tests

So far a generator function has added to create Date structs, including the accompanying tests.

The implementation for Time, DateTime and NaiveDateTime will be similar, except that their unit of offset will be fractions of milliseconds (rather than days), and of course the Date.Range-related code does not apply.

Since their implementation will be very similar, this seemed like a good moment to give you the opportunity to provide initial feedback on the code.

Happy holidays! 🎆

@Qqwy Qqwy changed the title WIP: Date time generators WIP: Date & time generators Dec 30, 2021
@Qqwy
Copy link
Contributor Author

Qqwy commented Jan 3, 2022

@whatyouhide Just a gentle reminder in case the notification of this PR slipped through the cracks.

Of course, take your time, and happy new-year's holidays! 😊

@Qqwy Qqwy changed the title WIP: Date & time generators WaitingForFeedback: Date & time generators Jan 4, 2022
lib/stream_data.ex Show resolved Hide resolved
lib/stream_data.ex Outdated Show resolved Hide resolved
lib/stream_data.ex Outdated Show resolved Hide resolved
lib/stream_data.ex Outdated Show resolved Hide resolved
lib/stream_data.ex Outdated Show resolved Hide resolved
@whatyouhide
Copy link
Owner

I like where this is going. Is there any way we can use Date.add/2 (and eventually DateTime.add/3 and friends) here instead of converting between days and dates?

@Qqwy
Copy link
Contributor Author

Qqwy commented Jan 21, 2022

I like where this is going. Is there any way we can use Date.add/2 (and eventually DateTime.add/3 and friends) here instead of converting between days and dates?

I think this should be possible, at least for most of the cases. 👍

@Qqwy Qqwy changed the title WaitingForFeedback: Date & time generators WIP: Date & time generators Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants