-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Date & time generators #161
base: main
Are you sure you want to change the base?
Conversation
(which were used for easier development)
internal helper functions
and clean up code slightly
@whatyouhide Just a gentle reminder in case the notification of this PR slipped through the cracks. Of course, take your time, and happy new-year's holidays! 😊 |
I like where this is going. Is there any way we can use |
I think this should be possible, at least for most of the cases. 👍 |
Implementation of #129
So far a generator function has added to create
Date
structs, including the accompanying tests.The implementation for
Time
,DateTime
andNaiveDateTime
will be similar, except that their unit of offset will be fractions of milliseconds (rather than days), and of course theDate.Range
-related code does not apply.Since their implementation will be very similar, this seemed like a good moment to give you the opportunity to provide initial feedback on the code.
Happy holidays! 🎆