Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable fragment case in "in cell" insertion mode #9810

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Remove unreachable fragment case in "in cell" insertion mode #9810

merged 2 commits into from
Nov 16, 2023

Conversation

not-my-profile
Copy link
Contributor

@not-my-profile not-my-profile commented Sep 29, 2023 •
edited by pr-preview bot
Loading

Fixes #7242.

/parsing.html ( diff )

@not-my-profile not-my-profile force-pushed the remove-unreachable-fragment-case branch from d6d59aa to 9c2a9dd Compare September 29, 2023 08:06
@domenic domenic requested review from zcorpan and hsivonen October 24, 2023 01:20
zcorpan
zcorpan reviewed Oct 24, 2023
View reviewed changes
source Outdated Show resolved Hide resolved
hsivonen
hsivonen suggested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to see an Infra Assert added.

source Outdated Show resolved Hide resolved
@zcorpan zcorpan merged commit ab63afc into whatwg:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsivonen hsivonen hsivonen requested changes

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
topic: parser
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"A start tag whose tag name is one of: "caption"..."
4 participants
@not-my-profile @zcorpan @hsivonen @domenic