Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove two wrong "(fragment case)" annotations #9792

Merged

Conversation

not-my-profile
Copy link
Contributor

@not-my-profile not-my-profile commented Sep 26, 2023

They can both occur even in regular (non-fragment) parsing, e.g. when parsing <template><body> and <template><frameset>.

As per the definition of "fragment case" such annotations are solely informational, so this fix is also non-normative.


/parsing.html ( diff )

They can both occur even in regular (non-fragment) parsing,
e.g. when parsing `<template><body>` and `<template><frameset>`.

As per the definition of "fragment case" such annotations are
solely informational, so this fix is also non-normative.
@not-my-profile
Copy link
Contributor Author

(I assume this should be classified as Editorial: since it's non-normative?)

@annevk annevk requested a review from hsivonen September 26, 2023 11:05
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/whatwg/meta/blob/main/COMMITTING.md#title-prefixes explains when we use Editorial. I guess I would opt to not prefix this change, but I will readily admit it's tricky.

source Outdated Show resolved Hide resolved
@domenic domenic added clarification Standard could be clearer topic: parser labels Oct 23, 2023
@domenic domenic requested a review from zcorpan October 24, 2023 01:19
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That these assertions are incomplete was identified 10 years ago by the person who implemented template for Gecko, but as a reviewer I failed to notice that a spec bug needed filing. Sorry! (Or perhaps the template stuff hadn't been merged to the main spec at that point in time?)

I think that instead of merely removing the assertion, it would be more helpful to update the assertion to say "fragment case or there is a template element on the stack" (which is how the assertion was update in Gecko).

@zcorpan
Copy link
Member

zcorpan commented Nov 16, 2023

I've pushed a commit to add the text @hsivonen suggested.

Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message when merging:

Correct two "fragment case" annotations

They can both occur even in regular (non-fragment) parsing,
e.g. when parsing `<template><body>` and `<template><frameset>`.

@zcorpan zcorpan merged commit 0c7c233 into whatwg:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: parser
Development

Successfully merging this pull request may close these issues.

5 participants