Editorial: remove redundant decimal character reference start state#12707
Merged
Conversation
The numeric character reference state can dispatch on ASCII digits directly and reconsume in the decimal character reference state, so the separate start state was pure indirection. The removed state's generated ID is preserved on the ASCII digit case for existing anchors. Fixes #2733.
sideshowbarker
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The numeric character reference state can dispatch on ASCII digits directly and reconsume in the decimal character reference state, so the separate start state was pure indirection.
This is editorial with no change in behavior: the same
absence-of-digits-in-numeric-character-referenceparse error, flush, and reconsume-in-return-state all occur as before. The removed state's generated ID is preserved on the ASCII digit case so existing anchors keep working.Fixes #2733.
/index.html ( diff )
/parsing.html ( diff )