Restore data: URL matching for shared workers via constructor storage key#12680
Merged
Conversation
… key When the shared worker lookup was changed to compare storage keys (5aa1a59), the SharedWorkerGlobalScope constructor origin comparison was dropped. The replacement derived the worker storage key from the worker's own settings object, but a data: URL worker has a unique opaque origin, so its storage key could never equal the creating environment's. This meant a data: URL shared worker could never be found and reused, even by the page that created it, and it left the constructor origin concept referenced only by a now-inaccurate note. Replace the constructor origin concept with a constructor storage key, initialized from the creating environment's storage key, and compare that against the outside storage key during lookup. This restores data: URL reuse while respecting storage key partitioning (origin and top-level site), and fixes the note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the shared worker lookup was changed to compare storage keys (5aa1a59), the SharedWorkerGlobalScope constructor origin comparison was dropped. The replacement derived the worker storage key from the worker's own settings object, but a data: URL worker has a unique opaque origin, so its storage key could never equal the creating environment's. This meant a data: URL shared worker could never be found and reused, even by the page that created it, and it left the constructor origin concept referenced only by a now-inaccurate note.
Replace the constructor origin concept with a constructor storage key, initialized from the creating environment's storage key, and compare that against the outside storage key during lookup. This restores data: URL reuse while respecting storage key partitioning (origin and top-level site), and fixes the note.
Skipping the template as this is a regression fix. This behavior was never intended to be changed.
/workers.html ( diff )