Editorial: Fix whitespace, punctuation, wording, markup#11387
Conversation
... because having the defined var *after* the 'be' is weird.
That appears to be the convention.
The spec has 78 occurrences of `<p>Otherwise:</p>`. In 61 of those, this is followed by an `<ol>`. In the remaining 17, it's followed by a sequence of `<p>` at the same 'level', which is a bit odd. This commit makes those 17 cases consistent with the rest: - wrap the sequence in `<ol>..</ol>`, - indent each `<p>` and wrap it in `<li>..</li>`
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM with some small suggested inline improvements on areas you're already improving. Notes:
| <span>text track</span>'s <code data-x="">trak</code> box in the | ||
| first <code data-x="">moov</code> box | ||
| of the file be the <i>stsd box</i>, if any. | ||
| of the file, if any. |
There was a problem hiding this comment.
It would be better to do this as ", or null if no such stsd box exist".
Then the next line can be "If stsd box is null, or if...".
| <dt>If the <span>media resource</span> is an MPEG-4 file</dt> | ||
|
|
||
| <dd>Let the | ||
| <dd>Let the <var>stsd box</var> be the |
There was a problem hiding this comment.
Here and below it'd be best to remove "the" before variable reference, since we're now treating stsd box as a real variable.
There was a problem hiding this comment.
Done.
(Grepping for the <var> in the source finds about 350. Is there a desire to get rid of all of them, or are there cases in which the preceding "the" is okay?)
There was a problem hiding this comment.
I think some cases seem to be OK, e.g. The <var>before</var> argument, the <var>index</var>th element, the <var>memory</var> map. Others seem incorrect, e.g. the <var>el</var> was created by the parser, If the <var>claimed type</var> is known, with, as its value, the <var>target URL</var>.
| data-x="fetching-scripts-perform-fetch">perform the fetch hook</span> given <var>request</var>, | ||
| <i data-x="fetching-scripts-is-top-level">isTopLevel</i> and <i | ||
| data-x="fetching-scripts-processCustomFetchResponse">processCustomFetchResponse</i>:</p> | ||
| <var data-x="fetching-scripts-is-top-level">isTopLevel</var> and <var |
There was a problem hiding this comment.
| <var data-x="fetching-scripts-is-top-level">isTopLevel</var> and <var | |
| <var data-x="fetching-scripts-is-top-level">isTopLevel</var>, and <var |
There was a problem hiding this comment.
Done, plus I found another.
2 participants
As usual.
/canvas.html ( diff )
/common-dom-interfaces.html ( diff )
/common-microsyntaxes.html ( diff )
/dnd.html ( diff )
/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/iframe-embed-object.html ( diff )
/image-maps.html ( diff )
/images.html ( diff )
/index.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/links.html ( diff )
/media.html ( diff )
/nav-history-apis.html ( diff )
/parsing.html ( diff )
/popover.html ( diff )
/rendering.html ( diff )
/semantics.html ( diff )
/server-sent-events.html ( diff )
/structured-data.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )