Skip to content

Discourage document.writeln() like document.write()#11384

Merged
annevk merged 1 commit into
whatwg:mainfrom
caugner:7977-discourage-document-writeln
Jun 20, 2025
Merged

Discourage document.writeln() like document.write()#11384
annevk merged 1 commit into
whatwg:mainfrom
caugner:7977-discourage-document-writeln

Conversation

@caugner

@caugner caugner commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Discourage document.writeln() for the same reasons as document.write()

See: #7977 (comment)

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/dynamic-markup-insertion.html ( diff )

@caugner
caugner force-pushed the 7977-discourage-document-writeln branch from 3ad0cb8 to 92af19a Compare June 17, 2025 12:14
@caugner
caugner force-pushed the 7977-discourage-document-writeln branch from 92af19a to f5bc070 Compare June 17, 2025 12:25

@annevk annevk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo formatting this seems okay to me.

Comment thread source Outdated
@annevk

annevk commented Jun 18, 2025

Copy link
Copy Markdown
Member

@zcorpan could you please work with @caugner on getting the Participation check resolved?

@caugner

caugner commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@zcorpan could you please work with @caugner on getting the Participation check resolved?

@annevk This should be resolved now (thanks again @zcorpan). 🙂

@annevk

annevk commented Jun 19, 2025

Copy link
Copy Markdown
Member

You need to make your membership of the organization public. Also please don't create merge commits in the future. Especially when they're not needed.

Co-authored by: Anne van Kesteren <annevk@annevk.nl>
@caugner
caugner force-pushed the 7977-discourage-document-writeln branch from dbab1aa to f6a112b Compare June 19, 2025 21:50
@caugner

caugner commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

You need to make your membership of the organization public.

Done, I was not aware.

Also please don't create merge commits in the future. Especially when they're not needed.

Sure, no problem. My intention here was to re-trigger the checks (which didn't work). I have rebased and squashed the two commits now.

@annevk
annevk merged commit 942e63d into whatwg:main Jun 20, 2025
2 checks passed
@annevk

annevk commented Jun 20, 2025

Copy link
Copy Markdown
Member

Thanks for fixing this!

@caugner
caugner deleted the 7977-discourage-document-writeln branch June 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants