Discourage document.writeln() like document.write()#11384
Merged
Conversation
caugner
force-pushed
the
7977-discourage-document-writeln
branch
from
June 17, 2025 12:14
3ad0cb8 to
92af19a
Compare
This was referenced Jun 17, 2025
caugner
force-pushed
the
7977-discourage-document-writeln
branch
from
June 17, 2025 12:25
92af19a to
f5bc070
Compare
annevk
approved these changes
Jun 17, 2025
annevk
left a comment
Member
There was a problem hiding this comment.
Modulo formatting this seems okay to me.
Member
Member
|
You need to make your membership of the organization public. Also please don't create merge commits in the future. Especially when they're not needed. |
Co-authored by: Anne van Kesteren <annevk@annevk.nl>
caugner
force-pushed
the
7977-discourage-document-writeln
branch
from
June 19, 2025 21:50
dbab1aa to
f6a112b
Compare
Contributor
Author
Done, I was not aware.
Sure, no problem. My intention here was to re-trigger the checks (which didn't work). I have rebased and squashed the two commits now. |
Member
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discourage
document.writeln()for the same reasons asdocument.write()See: #7977 (comment)
(See WHATWG Working Mode: Changes for more details.)
/dynamic-markup-insertion.html ( diff )