Editorial: reorganise dialog algorithms to end of section #10977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
added
clarification
domenic
approved these changes
Feb 3, 2025
keithamus
deleted the
editorial-reorganise-dialog-algorithms-to-end-of-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This editorial PR closes #10963 by reorganizing the dialog algorithms to the end of the Dialog section, just above the "dialog light dismiss" header. This PR only moves text around, the diff is messy but no words or markup have been altered.
I had considered also moving out the dialog
show()andrequestClose()methods into separate algorithms, leaving their respective steps as skeletons that call out to the algorithms, as I think this would read better, but left it for another PR, if the editors see it as an improvement./interactive-elements.html ( diff )