editorial: group dialog member variables #10967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
clarification
domenic
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Thanks for this and all the others! What do you think of the following additional small improvements?
- Also fix the phrasing from "The
Documenthas" to "EachDocumenthas". - Move the "Each HTML element" item under the document? To me it feels like Document, then each HTML element, then dialog is slightly better ordering, with more-specific-ish stuff last.
keithamus
force-pushed
the
editorial-group-dialog-member-variables
branch
from
2775830 to
960c1d3
Compare
|
Okay both improvements have been made. |
domenic
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This editorial PR (refs #10963) moves the
dialog toggle task trackermember within its other member siblings; and rewords them to be similar - others sayEach dialog, but thedialog toggle task trackerwas sayingEvery dialog./interactive-elements.html ( diff )