Editorial section off content attributes with hrs #10965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Jan 31, 2025
There was a problem hiding this comment.
I think this should be after the definition of the "markup things" (including attributes), and right before we start defining the public API. I guess #10963 was not clear where the attribute definitions will go; I will amend it.
I might also suggest some more "<hr>?"s while I'm there.
keithamus
force-pushed
the
editorial-move-dialog-domintro-to-preamble
branch
from
fea2dc6 to
9e18408
Compare
keithamus
changed the title
keithamus
changed the title
keithamus
force-pushed
the
editorial-move-dialog-domintro-to-preamble
branch
from
9e18408 to
edddf52
Compare
keithamus
force-pushed
the
editorial-move-dialog-domintro-to-preamble
branch
from
edddf52 to
91ffbc0
Compare
|
Okay - the change here now effectively becomes just adding the hrs. |
domenic
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10964.
This editorial change (refs #10963) moves the dialog "domintro" section to be underneath all the other examples in the preamble section.
/interactive-elements.html ( diff )