[Editorial] rework button states to allow for command/commandfor attributes #10960
+52
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
reviewed
Jan 29, 2025
noamr
reviewed
Jan 29, 2025
noamr
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way button elements represent their state; specifically how they are defined as submit buttons. This also re-writes some of the generic algorithms (such as the IDL reflection) to be manual steps.
The intent of this change is to carve out the space for the new
commandandcommandforattributes. Most of these changes are already in #9841 but this PR separates them out to shrink the amount of changes inside #9841./form-elements.html ( diff )