Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSP navigation request blocking #10949

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix CSP navigation request blocking #10949

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8953208
Fix CSP navigation request blocking
domenic Jan 27, 2025
e88eb0a
Pass CSP list instead, and fix another call site.
domenic Jan 28, 2025
68874af
Set the request's policy container instead
domenic Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100144,8 +100144,8 @@ location.href = '#foo';</code></pre>
<dd><var>sourceDocument</var>'s <span>relevant settings object</span></dd>

<dt><span data-x="source-snapshot-params-policy-container">source policy container</span></dt>
<dd><var>sourceDocument</var>'s <span data-x="concept-document-policy-container">policy
container</span></dd>
<dd>a <span data-x="clone a policy container">clone</span> of <var>sourceDocument</var>'s <span
data-x="concept-document-policy-container">policy container</span></dd>
</dl>

<hr>
Expand Down Expand Up @@ -100541,8 +100541,9 @@ location.href = '#foo';</code></pre>
<li><p><span>Queue a global task</span> on the <span>navigation and traversal task
source</span> given <var>navigable</var>'s <span data-x="nav-window">active window</span> to
<span>navigate to a <code>javascript:</code> URL</span> given <var>navigable</var>,
<var>url</var>, <var>historyHandling</var>, <var>initiatorOriginSnapshot</var>,
<var>userInvolvement</var>, and <var>cspNavigationType</var>.</p></li>
<var>url</var>, <var>historyHandling</var>, <var>sourceSnapshotParams</var>,
<var>initiatorOriginSnapshot</var>, <var>userInvolvement</var>, and
<var>cspNavigationType</var>.</p></li>

<li><p>Return.</p></li>
</ol>
Expand Down Expand Up @@ -100915,8 +100916,9 @@ location.href = '#foo';</code></pre>

<p>To <dfn>navigate to a <code>javascript:</code> URL</dfn>, given a <span>navigable</span>
<var>targetNavigable</var>, a <span>URL</span> <var>url</var>, a <span>history handling
behavior</span> <var>historyHandling</var>, an <span>origin</span> <var>initiatorOrigin</var>, a
<span>user navigation involvement</span> <var>userInvolvement</var>, and a string
behavior</span> <var>historyHandling</var>, a <span>source snapshot params</span>
<var>sourceSnapshotParams</var>, an <span>origin</span> <var>initiatorOrigin</var>, a <span>user
navigation involvement</span> <var>userInvolvement</var>, and a string
<var>cspNavigationType</var>:</p>

<ol>
Expand All @@ -100931,7 +100933,10 @@ location.href = '#foo';</code></pre>

<li>
<p>Let <var>request</var> be a new <span data-x="concept-request">request</span> whose <span
data-x="concept-request-url">URL</span> is <var>url</var>.</p>
data-x="concept-request-url">URL</span> is <var>url</var> and whose <span
data-x="concept-request-policy-container">policy container</span> is
<var>sourceSnapshotParams</var>'s <span data-x="source-snapshot-params-policy-container">source
policy container</span>.</p>

<p class="note">This is a synthetic <span data-x="concept-request">request</span> solely for
plumbing into the next step. It will never hit the network.</p>
Expand Down Expand Up @@ -102603,6 +102608,10 @@ location.href = '#foo';</code></pre>
<dt><span data-x="concept-request-referrer-policy">referrer policy</span></dt>
<dd><var>entry</var>'s <span data-x="she-document-state">document state</span>'s <span
data-x="document-state-request-referrer-policy">request referrer policy</span></dd>

<dt><span data-x="concept-request-policy-container">policy container</span></dt>
<dd><var>sourceSnapshotParams</var>'s <span
data-x="source-snapshot-params-policy-container">source policy container</span></dd>
</dl>
</li>

Expand Down