Code

Add dialog light dismiss behavior#10737

Code

Merged

domenic merged 28 commits intowhatwg:mainwhatwg/html:mainfrom mfreed7:closedbymfreed7/html:closedbyCopy head branch name to clipboardJan 15, 2025

+337-52

Commits

Commits on Nov 16, 2024

• Add closedby attribute to <dialog>

  Show description for 4a93ad6
  mfreed7

  committed
  4a93ad6

  Copy full SHA for 4a93ad6

• Small tweaks

  mfreed7

  committed
  3630019

  Copy full SHA for 3630019

• Add requestClose()

  mfreed7

  committed
  32c2240

  Copy full SHA for 32c2240

• Fix tag nesting

  mfreed7

  committed
  78f9789

  Copy full SHA for 78f9789

• Move note out of OL

  mfreed7

  committed
  b99c5ac

  Copy full SHA for b99c5ac

• Address comments

  mfreed7

  committed
  8698d0b

  Copy full SHA for 8698d0b

• Check for open attribute

  mfreed7

  committed
  f50198e

  Copy full SHA for f50198e

• Adjust algorithm to match impl and tests

  mfreed7

  committed
  fb01762

  Copy full SHA for fb01762

• Address comments

  mfreed7

  committed
  4f205bd

  Copy full SHA for 4f205bd

• Update attribute index

  mfreed7

  committed
  38bdafe

  Copy full SHA for 38bdafe

• Adjustments from dbaron

  mfreed7

  committed
  873e451

  Copy full SHA for 873e451

• Fix up the return value

  mfreed7

  committed
  e7fbbec

  Copy full SHA for e7fbbec

• Fix up closewatcher

  mfreed7

  committed
  8b019a4

  Copy full SHA for 8b019a4

• Fix up ol/li/p

  mfreed7

  committed
  b57968e

  Copy full SHA for b57968e

• Some cleanup

  mfreed7

  committed
  ea474af

  Copy full SHA for ea474af

• Fix "empty" xref

  mfreed7

  committed
  db56191

  Copy full SHA for db56191

Commits on Nov 21, 2024

• Address domenic@ comments

  mfreed7

  committed
  82a4561

  Copy full SHA for 82a4561

Commits on Dec 2, 2024

• Address annevk comments

  mfreed7

  committed
  6a9e20b

  Copy full SHA for 6a9e20b

Commits on Dec 5, 2024

• Change behavior to only close topmost dialog

  mfreed7

  committed
  20dc2fe

  Copy full SHA for 20dc2fe

Commits on Dec 6, 2024

• Remove extra section

  mfreed7

  committed
  f5a0919

  Copy full SHA for f5a0919

• Remove exception

  mfreed7

  committed
  3f413d3

  Copy full SHA for 3f413d3

• Add closewatcher override for requestClose

  mfreed7

  committed
  d9ed19f

  Copy full SHA for d9ed19f

Commits on Dec 9, 2024

• Address 2 nits

  mfreed7

  committed
  ff98f98

  Copy full SHA for ff98f98

Commits on Dec 10, 2024

• Address domenic comments

  mfreed7

  committed
  2fb87b1

  Copy full SHA for 2fb87b1

• Side-step closewatcher abuse prevention

  mfreed7

  committed
  6aa7386

  Copy full SHA for 6aa7386

Commits on Dec 11, 2024

• allowPreventClose -> requireHistoryActionActivation

  mfreed7

  committed
  344d87f

  Copy full SHA for 344d87f

Commits on Dec 12, 2024

• Change closeWatcher.requestClose() also

  mfreed7

  committed
  76619aa

  Copy full SHA for 76619aa

• Address two comments

  mfreed7

  committed
  57df925

  Copy full SHA for 57df925