Merge offscreen and onscreen CanvasRenderingContext2DSettings · whatwg/html@8927cc6

Kaiido · 2025-01-07T22:49:34Z

I personally think it's great the API is unified, thanks.

However I have a small worry about the name CanvasBitmap for the interface. I fear this will be confusing with the output bitmap. It's currently ill-specified while referenced a lot, but in #9537 @graveljp is rewriting it all with a canvas-bitmap, a context's top-level output bitmap, and layer's output-bitmap.
Unfortunately I don't really have a better proposition at the moment.

ccameron-chromium · 2025-01-08T09:54:12Z

On Tue, Jan 7, 2025 at 11:49 PM Tristan Fraipont ***@***.***> wrote: I personally think it's great the API is unified, thanks. However I have a small worry about the name CanvasBitmap for the interface. I fear this will be confusing with the output *bitmap*. It's currently ill-specified while referenced a lot, but in #9537 <#9537> @graveljp <https://github.com/graveljp> is rewriting it all with a canvas-bitmap <https://whatpr.org/html/9537/canvas.html#canvas-bitmap>, a context's top-level output bitmap <https://whatpr.org/html/9537/canvas.html#top-level-output-bitmap>, and layer's output-bitmap <https://whatpr.org/html/9537/canvas.html#output-bitmap>. Unfortunately I don't really have a better proposition at the moment.

Thanks! I, too, don't like the name. The original explainer went with CanvasSettings, then I switched to CanvasBitmap, and, given your feedback, I've changed it back to CanvasSettings. I also moved the initialization of the output bitmap into CanvasSettings, as the "canvas settings output bitmap initialization algorithm", which makes me feel better about something named CanvasSettings being the interface that owns the bitmap.

…

— Reply to this email directly, view it on GitHub <8927cc6#commitcomment-151024397>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYMQNNGELQIHD2AJEPJUVD2JRKZHAVCNFSM6AAAAABUYVMPSKVHI2DSMVQWIX3LMV43OQ3PNVWWS5CDN5WW2ZLOOQ5TCNJRGAZDIMZZG4> . You are receiving this because you authored the thread.Message ID: <whatwg/html/commit/8927cc6bf5ba0684f839c72fc76c2fb9a8cf7c67/151024397@ github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit

There are no files selected for viewing

2 comments on commit `8927cc6`

Kaiido commented on `8927cc6` Jan 7, 2025

ccameron-chromium commented on `8927cc6` Jan 8, 2025 via email

Commit

There are no files selected for viewing

2 comments on commit 8927cc6

Kaiido commented on 8927cc6 Jan 7, 2025

Choose a reason for hiding this comment

ccameron-chromium commented on 8927cc6 Jan 8, 2025 via email

Choose a reason for hiding this comment

2 comments on commit `8927cc6`

Kaiido commented on `8927cc6` Jan 7, 2025

ccameron-chromium commented on `8927cc6` Jan 8, 2025 via email