Consistently trim whitespace from name and value #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also slowly start modernizing some algorithm conventions. Tests: ... Fixes #276.
valenting
approved these changes
Aug 8, 2025
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Aug 8, 2025
https://bugs.webkit.org/show_bug.cgi?id=297118 Reviewed by NOBODY (OOPS!). The specification already covers set() and whatwg/cookiestore#281 will cover get(), getAll(), and delete() for consistency. subscribe() and unsubscribe() are not covered by this PR. They are not shipping and have various outstanding specification issues. This also removes an unused argument from CookieStore::MainThreadBridge::set. While using trim() I also discovered that the comments in Source/WTF/wtf/text/StringImpl.cpp were out-of-date so this updates those as well.
DCtheTall
approved these changes
Aug 8, 2025
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Aug 9, 2025
https://bugs.webkit.org/show_bug.cgi?id=297118 Reviewed by Rupin Mittal. The specification already covers set() and whatwg/cookiestore#281 will cover get(), getAll(), and delete() for consistency. subscribe() and unsubscribe() are not covered by this PR. They are not shipping and have various outstanding specification issues. This also removes an unused argument from CookieStore::MainThreadBridge::set. While using trim() I also discovered that the comments in Source/WTF/wtf/text/StringImpl.cpp were out-of-date so this updates those as well. Canonical link: https://commits.webkit.org/298470@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also slowly start modernizing some algorithm conventions.
Tests: web-platform-tests/wpt#54211
Fixes #276.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff