Refactor Map Compose components for performance and stability#144
Merged
Refactor Map Compose components for performance and stability#144
Conversation
- Optimize `content` lambda recomposition using `movableContentOf` in both `W3WGoogleMap` and `W3WMapBox`. - Reorder `W3WGoogleMap` parameters to support trailing lambda for `content` and provide a default `Modifier`. - Remove unnecessary coroutine context switching in `updateCameraBound` to simplify bounds calculation. - Safely handle `IllegalStateException` in `updateCameraBound` when accessing `latLngBounds` before the map layout is fully ready.
phpduy
requested review from
QuocNguyen-w3w,
linhha2000,
mani-apps and
nghianguyen-w3w
QuocNguyen-w3w
approved these changes
Mar 2, 2026
mani-apps
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contentlambda recomposition usingmovableContentOfin bothW3WGoogleMapandW3WMapBox.W3WGoogleMapparameters to support trailing lambda forcontentand provide a defaultModifier.updateCameraBoundto simplify bounds calculation.IllegalStateExceptioninupdateCameraBoundwhen accessinglatLngBoundsbefore the map layout is fully ready.