Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new plugin: Data Scrub #9296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

polmih
Copy link
Contributor

@polmih polmih commented Mar 2, 2022

What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?

A clear and concise description of what the code of this PR accomplishes. /// Une description claire et concise de ce que le code de cette PR accompli.

This plugin will delete the potential Personal Identifiable Information (PII) before a form submit.

A popup message will inform the user if any fields contain personal information and will show the output of the scrubbed data. The user can choose to go back to the form to delete the data or to proceed with scrubbing the personal information and the form submission;

This plugin will work with any standard form.
This plugin will not support Form validation plugin or Postback plugin to be executed on the same form.

In order to activate this plugin on a form:

the form fields that needs to be scrubbed should have the following data attribute : data-rule-wbscrub ;

@polmih polmih force-pushed the wb-data-scrub branch 2 times, most recently from 8f39ce3 to fd49eb6 Compare March 2, 2022 22:11
@polmih polmih force-pushed the wb-data-scrub branch 3 times, most recently from d76ea38 to b8fdeda Compare March 3, 2022 19:07
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default action should be first and in primary color. Do we want the person to "agree" the removal of the information or do we want the user to let's scrub and move forward?

src/plugins/wb-data-scrub/wb-data-scrub.js Outdated Show resolved Hide resolved
src/plugins/wb-data-scrub/wb-data-scrub.js Outdated Show resolved Hide resolved
src/plugins/wb-data-scrub/wb-data-scrub.js Outdated Show resolved Hide resolved
src/plugins/wb-data-scrub/wb-data-scrub.js Outdated Show resolved Hide resolved
src/plugins/wb-data-scrub/wb-data-scrub.js Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to have the "test" case after the working example.

@polmih
Copy link
Contributor Author

polmih commented Mar 4, 2022

I suggest to have the "test" case after the working example.

Done. Thanks

event.preventDefault();
var isPii = false,
moDalId = componentName + "-modal",
i18nDict = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to define the i18nDict, instead retrieve it from wb.

Something like: https://github.com/wet-boew/wet-boew/blob/master/src/plugins/multimedia/multimedia.js#L108-L120

@duboisp duboisp added the State: Going Stale Historically used to identify a issue that didn't got immediate and active public interest. label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Going Stale Historically used to identify a issue that didn't got immediate and active public interest.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants