WET-484 Rotating features for Home and News #2424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricokola
had a problem deploying
to
github-ci
GitHub Actions
Failure
duboisp
requested changes
Sep 18, 2024
duboisp
requested changes
Sep 18, 2024
duboisp
requested changes
Sep 19, 2024
| </div> | ||
| </form> | ||
| </details> | ||
| <section class="lnkbx well"> |
There was a problem hiding this comment.
@duboisp I've deprecated the version 2 of the working example as it was implemented. The "lnkbx" class add a margin-bottom of 10 pixels to every list item of the "Resources" section. I don't see any value of having this class.
Comment on lines
+13
to
+21
| <div class="mrgn-bttm-md" data-wb-randomize='{ "shuffle": true, "selector": "a", "toggle": "hide" }'> | ||
| <a href="#" class="hide"> | ||
| <figure> | ||
| <img class="img-responsive full-width" src="https://via.placeholder.com/1170x347/F5F5F5/000000.png" alt=""> | ||
| <figcaption class="well brdr-rds-0"> | ||
| <span class="h4 mrgn-tp-0 mrgn-bttm-0 mrgn-lft-0">Image caption</span> | ||
| </figcaption> | ||
| </figure> | ||
| </a> |
There was a problem hiding this comment.
That is a deprecated pattern when compared to our contextual feature pattern.
There was a problem hiding this comment.
@duboisp When deprecating a version do we need to modify the content or we should deprecated as is?
| </figure> | ||
| </a> | ||
| </div> | ||
| <div class="clearfix"> |
There was a problem hiding this comment.
clearfix ? That would not be needed when using the bootstrap grid
Comment on lines
+195
to
+196
| <div class="col-md-9"> | ||
| <table class="wb-tables table nws-tbl" id="dataset-filter" aria-live="polite" data-wb-tables='{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.