Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard plugin (méli-mélo): Restore space indents #2422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricDunsworth
Copy link
Member

#2411 accidentally-introduced tab indents into the plugin's JS file.

It was caused by a clash of EditorConfig settings (which apply GCWeb's basic linting settings to all méli-mélo files) vs ESLint (which excludes méli-mélo). The added indents adhered to the EditorConfig settings, but the file itself was using a different kind of indent style (groups of 4 spaces).

This changes the tab characters back into spaces.

wet-boew#2411 accidentally-introduced tab indents into the plugin's JS file.

It was caused by a clash of EditorConfig settings (which apply GCWeb's basic linting settings to all méli-mélo files) vs ESLint (which excludes méli-mélo). The added indents adhered to the EditorConfig settings, but the file itself was using a different kind of indent style (groups of 4 spaces).

This changes the tab characters back into spaces.
@Garneauma
Copy link
Contributor

Pre-approved upon successful review. Also will need to check the warning about "The head ref may contain hidden characters: "clipboard-m\u00E9li-m\u00E9lo-restore-space-indents"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants