Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET-boew -> GCWeb ->Simple example pages #2409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastianBurke
Copy link
Contributor

@SebastianBurke SebastianBurke commented Aug 1, 2024

Simple example pages with corresponding component references for the following components:
ajax-fetch
json-fetch
navcurrent
resize
wb-focus

Also a minor fix for the geomap index.json-ld file where an english example page had a language value of "fr"

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianBurke

  • Fix the URLs to the example pages for Navcurrent and Resize (make sure the language toggle also works)
  • Remove the class "list-inline" from the list of events and list of components. It is not necessary

@SebastianBurke
Copy link
Contributor Author

Made the changes @Garneauma
I am unsure if I made all the changes you requested to Navcurrent and resize - please confirm, thanks!

@Garneauma
Copy link
Contributor

Pre-approved upon successful review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants