Theme: adding theme template #2390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garneauma
force-pushed
the
theme-template
branch
from
eaa72f5
to
d5acf8d
Compare
duboisp
requested changes
Jul 16, 2024
There was a problem hiding this comment.
J'adore la restructuration que tu as fais du markup de la page. Good job.
Il va falloir ajouter une page d'exemple soit pour le dernier menu item ou soit pour un des avants derniers item du menu. Ceci afin de bien voir l'effet de la class "active" qui est utilisé dans le menu de gauche pour identifier l'item courant.
Garneauma
force-pushed
the
theme-template
branch
from
d5acf8d
to
6dd44be
Compare
Garneauma
force-pushed
the
theme-template
branch
from
6dd44be
to
01f3e24
Compare
Garneauma
force-pushed
the
theme-template
branch
from
01f3e24
to
9519454
Compare
duboisp
requested changes
Aug 30, 2024
|
@Garneauma can you add in the request description our internal reference number associated with this PR? thanks |
Garneauma
force-pushed
the
theme-template
branch
from
9519454
to
8506ffc
Compare
Garneauma
had a problem deploying
to
github-ci
GitHub Actions
Failure
Garneauma
force-pushed
the
theme-template
branch
from
8506ffc
to
d019dbd
Compare
Garneauma
force-pushed
the
theme-template
branch
from
d019dbd
to
239e198
Compare
Garneauma
force-pushed
the
theme-template
branch
from
239e198
to
30b99f9
Compare
Garneauma
force-pushed
the
theme-template
branch
from
30b99f9
to
d9be7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on PR #2410 being merged.
Changes related to: WET-467