Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content - Spacing and Borders - Created Example Pages #2275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastianBurke
Copy link
Contributor

Accidentally deleted old PR while trying to amend.
Changes reflected here

@duboisp duboisp added the Query: Project item Part of a github project label Feb 14, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to re-create the commit because it is tagged as a merge commit.

The easiest is to redo the change and then do a force push to your branch "spacing".

Let's connect to do that.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please add an example of each style documented in the card.

Thanks

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and the content look good.

Please apply the content re-ordering proposition.

Optionally, it will be great if you can update the heading with a human readable text which describe the associated demo.

Comment on lines +18 to +66
<h2><code>.margin-bottom-none</code></h2>
<div class="row">
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm ">
<div class="margin-bottom-none">No bottom Margin</div>
</div>
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm ">
<div class="margin-bottom-small margin-bottom-none">20 pixel bottom Margin</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="margin-bottom-none"&gt;&lt;/div&gt;
&lt;div class="margin-bottom-small margin-bottom-none"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<h2><code>.margin-bottom-small</code></h2>
<div class="row">
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="margin-bottom-small">Small bottom Margin</div>
</div>
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div>Default bottom Margin</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="margin-bottom-small"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<h2><code>.margin-top-large</code></h2>
<div class="row">
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="margin-top-large">Large top Margin</div>
</div>
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div>Default top Margin</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="margin-top-large"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<h2><code>.margin-top-medium</code></h2>
<div class="row">
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="margin-top-medium">Medium top Margin</div>
</div>
<div class="col-md-4 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div>Default top Margin</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="margin-top-medium"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move those example at the bottom of the page as they are not recommended. They were only added to ease a transition between WET 3 to WET 4.

Please put it in a section named "Spacing utility not recommended" followed by an expand/collapse to view those item where you will downgrade the h2 for an h3. Something like:

<h2>Spacing utilities that are not recommended</h2>
<details>
<summary>Only to ease fast content transition from WET 3 to WET 4</summary>

<h3><code>.margin-bottom-none</code></h3>
....

</details>

Comment on lines +79 to +160
<div>
<h2><code>.mrgn-*-*</code></h2>
<div class="container ">
<div class="row ">
<div class="col-sm-6 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="mrgn-lft-0 bg-info ">Left margin 0</div>
<div class="mrgn-lft-sm bg-info ">Left margin small (5px)</div>
<div class="mrgn-lft-md bg-info ">Left margin medium (15px)</div>
<div class="mrgn-lft-lg bg-info ">Left margin large (30px)</div>
<div class="mrgn-lft-xl bg-info ">Left margin extra large (50px)</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="mrgn-lft-0"&gt;&lt;/div&gt;
&lt;div class="mrgn-lft-sm"&gt;&lt;/div&gt;
&lt;div class="mrgn-lft-md"&gt;&lt;/div&gt;
&lt;div class="mrgn-lft-lg"&gt;&lt;/div&gt;
&lt;div class="mrgn-lft-xl"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<div class="row ">
<div class="col-sm-6 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="mrgn-rght-0 bg-info ">Right margin 0</div>
<div class="mrgn-rght-sm bg-info ">Right margin small (5px)</div>
<div class="mrgn-rght-md bg-info ">Right margin medium (15px)</div>
<div class="mrgn-rght-lg bg-info ">Right margin large (30px)</div>
<div class="mrgn-rght-xl bg-info ">Right margin extra large (50px)</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="mrgn-rght-0"&gt;&lt;/div&gt;
&lt;div class="mrgn-rght-sm"&gt;&lt;/div&gt;
&lt;div class="mrgn-rght-md"&gt;&lt;/div&gt;
&lt;div class="mrgn-rght-lg"&gt;&lt;/div&gt;
&lt;div class="mrgn-rght-xl"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<div class="row ">
<div class="col-sm-6 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="mrgn-bttm-0 bg-info ">Bottom margin 0</div>
<div class="mrgn-bttm-sm bg-info ">Bottom margin small (5px)</div>
<div class="mrgn-bttm-md bg-info ">Bottom margin medium (15px)</div>
<div class="mrgn-bttm-lg bg-info ">Bottom margin large (30px)</div>
<div class="mrgn-bttm-xl bg-info ">Bottom margin extra large (50px)</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="mrgn-bttm-0"&gt;&lt;/div&gt;
&lt;div class="mrgn-bttm-sm"&gt;&lt;/div&gt;
&lt;div class="mrgn-bttm-md"&gt;&lt;/div&gt;
&lt;div class="mrgn-bttm-lg"&gt;&lt;/div&gt;
&lt;div class="mrgn-bttm-xl"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
<div class="row ">
<div class="col-sm-6 brdr-lft brdr-rght brdr-tp brdr-bttm">
<div class="mrgn-tp-0 bg-info ">Top margin 0</div>
<div class="mrgn-tp-sm bg-info ">Top margin small (5px)</div>
<div class="mrgn-tp-md bg-info ">Top margin medium (15px)</div>
<div class="mrgn-tp-lg bg-info ">Top margin large (30px)</div>
<div class="mrgn-tp-xl bg-info ">Top margin extra large (50px)</div>
</div>
<div class="col-md-4">
<pre><code>&lt;div class="mrgn-tp-0"&gt;&lt;/div&gt;
&lt;div class="mrgn-tp-sm"&gt;&lt;/div&gt;
&lt;div class="mrgn-tp-md"&gt;&lt;/div&gt;
&lt;div class="mrgn-tp-lg"&gt;&lt;/div&gt;
&lt;div class="mrgn-tp-xl"&gt;&lt;/div&gt;</code></pre>
</div>
</div>
</div>
</div>
<div class="container">
<h2>Demonstrating <code>.mt-auto</code> Effect</h2>
<div class="flex-container"
style="display: flex; flex-direction: column; height: 500px; background-color: #f0f0f0">
<div class="bg-info">Top Element: This is a standard flex item which
will stay at its natural position, which is at the top of the flex container.
</div>
<div class="mt-auto bg-info ">Bottom Element with .mt-auto:
By applying .mt-auto, this element takes up all available space on the top, effectively pushing
itself to the bottom of the flex container.
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move those items to be the first item in this example page.

</div>
</div>
<div>
<h2><code>.mrgn-*-*</code></h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is optional for the purpose of this working example but if you do it you will need to update all the other heading to be consistant. And do the same in French.

Ideally we will have a more meaningful name like:

Suggested change
<h2><code>.mrgn-*-*</code></h2>
<h2>Margin generic utilities - <code>.mrgn-*-*</code></h2>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Review completed, changes requested
Development

Successfully merging this pull request may close these issues.

2 participants