Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG upgrade: Create working example for: Scaffolding - Typography #2236

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BrahimMahadi
Copy link
Contributor

Created working example for testing with filled text (like “Lorem ipsum”) for: Scaffolding - Typography

@BrahimMahadi BrahimMahadi temporarily deployed to github-ci August 24, 2023 17:45 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Mar 6, 2024

@BrahimMahadi Please also fix the merge conflict. Thanks

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and tested locally, Everything work as expected except the 2 changes to do in both language.

  • remove the breadcrumb
  • Fix the broken link and use relative link instead.

common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typographie.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
common/scaffolding/typography.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Review completed, changes requested
Development

Successfully merging this pull request may close these issues.

2 participants