Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET-388 Pre-assessment for overlay #2218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephdiab
Copy link
Contributor

This was copied from wet-boew/src/plugins/overlay

@josephdiab josephdiab temporarily deployed to github-ci July 25, 2023 19:25 — with GitHub Actions Inactive
@josephdiab josephdiab changed the title Pre Accessibility Assessment for overlay WET-388 Pre-assessment for overlay Aug 3, 2023
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a minute, is this only the move of the overlay assessment from wet into GCWeb? It looks like it.

There is nothing that seems related to s pre-assessment of the overlay. And the move of the assessment + acr are going to happen only after the creation of a dedicated section for wet-boew.

@josephdiab let chat.


Note I was going to say:

Creating the pre-assessment should not have involved to add any css (scss) and js. neither to re-add the already existing working example.

Here the GCWeb working example of the overlay plugin:

Remove the conformance report (file ending with -arc) because we would only do that at later date.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ".hbs" file in GCWeb. Those need to be renamed for ".html"

FYI - The site building software are different between wet-boew and gcweb github repository. GCWeb do use Jekyll + automated github pages and wet-boew use handlebar + manual gh-page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not create the conformance report yet. That is something we are going to do later, after the majority of the assessment would be done.

Comment on lines +25 to +34
"foaf:name": "Hani Ahmed (Github: @heansih)",
"foaf:homepage": "https://github.com/heansih",
"@type": ["earl:Assertor", "foaf:Person"],
"foaf:member": {
"@id": "_:wave_browser_extension",
"doap:name": "WAVE web accessibility evaluation tool, browser extension",
"doap:homepage": "https://wave.webaim.org/extension/",
"@type": [ "earl:Assertor", "earl:Software" ]
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated with your name and github handle. It do identify who created this assessment report

Suggested change
"foaf:name": "Hani Ahmed (Github: @heansih)",
"foaf:homepage": "https://github.com/heansih",
"@type": ["earl:Assertor", "foaf:Person"],
"foaf:member": {
"@id": "_:wave_browser_extension",
"doap:name": "WAVE web accessibility evaluation tool, browser extension",
"doap:homepage": "https://wave.webaim.org/extension/",
"@type": [ "earl:Assertor", "earl:Software" ]
}
}
"foaf:name": "Your Name (Github: @yourGitHubHandle)",
"foaf:homepage": "https://github.com/yourGitHubHandle",
"@type": ["earl:Assertor", "foaf:Person"]
}

}
},

"dct:date": "2023-01-06",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date must be updated to when you did the assessment. It can be in January 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants