-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WET-388 Pre-assessment for overlay #2218
base: master
Are you sure you want to change the base?
Conversation
…ew/src/plugins/overlay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a minute, is this only the move of the overlay assessment from wet into GCWeb? It looks like it.
There is nothing that seems related to s pre-assessment of the overlay. And the move of the assessment + acr are going to happen only after the creation of a dedicated section for wet-boew.
@josephdiab let chat.
Note I was going to say:
Creating the pre-assessment should not have involved to add any css (scss) and js. neither to re-add the already existing working example.
Here the GCWeb working example of the overlay plugin:
- https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/overlay/overlay-en.html
- https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/overlay/overlay-fr.html
Remove the conformance report (file ending with -arc) because we would only do that at later date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no ".hbs" file in GCWeb. Those need to be renamed for ".html"
FYI - The site building software are different between wet-boew and gcweb github repository. GCWeb do use Jekyll + automated github pages and wet-boew use handlebar + manual gh-page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not create the conformance report yet. That is something we are going to do later, after the majority of the assessment would be done.
"foaf:name": "Hani Ahmed (Github: @heansih)", | ||
"foaf:homepage": "https://github.com/heansih", | ||
"@type": ["earl:Assertor", "foaf:Person"], | ||
"foaf:member": { | ||
"@id": "_:wave_browser_extension", | ||
"doap:name": "WAVE web accessibility evaluation tool, browser extension", | ||
"doap:homepage": "https://wave.webaim.org/extension/", | ||
"@type": [ "earl:Assertor", "earl:Software" ] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated with your name and github handle. It do identify who created this assessment report
"foaf:name": "Hani Ahmed (Github: @heansih)", | |
"foaf:homepage": "https://github.com/heansih", | |
"@type": ["earl:Assertor", "foaf:Person"], | |
"foaf:member": { | |
"@id": "_:wave_browser_extension", | |
"doap:name": "WAVE web accessibility evaluation tool, browser extension", | |
"doap:homepage": "https://wave.webaim.org/extension/", | |
"@type": [ "earl:Assertor", "earl:Software" ] | |
} | |
} | |
"foaf:name": "Your Name (Github: @yourGitHubHandle)", | |
"foaf:homepage": "https://github.com/yourGitHubHandle", | |
"@type": ["earl:Assertor", "foaf:Person"] | |
} |
} | ||
}, | ||
|
||
"dct:date": "2023-01-06", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This date must be updated to when you did the assessment. It can be in January 2023.
This was copied from wet-boew/src/plugins/overlay