Fix belongs_to polymorphic associations with "empty string" type #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
I have encountered the following issue while using this gem.
Issue:
When a model has a
belong_to
, polymorphic and optional association, and the model has<polymorphic_name>_type = ''
set, aNameError
exception is raised when saving the model.Example
When executing the following line, it fails with
NameError (wrong constant name )
This error raises in these lines of code
You can use this script to reproduce the issue.
IMO having
polymorphic_type =''
is allowed/supported by Rails, and this gem should not break when trying to versioning an association with this characteristic.