Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the sensible build... compatibly #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Artoria2e5
Copy link

@Artoria2e5 Artoria2e5 commented Dec 28, 2019

We try to use the "sensible" build when possible, handling all the old
try/catch magic in catsrc. This mostly works, except for a problem in
the parser that appears to be also present in a previous version: a
huge object tries to reference things that don't exist.

[The site is unchanged for now to avoid breaking any new things.
Somebody added a // comment to CSS which is invalid, so expect it to not
work. I did not break it.]

The eslint rules are enabled. They don't really hit any package problems
any more, so I figure it's time to turn them on. I added an rc for the
tests so every complaint left is a true positive now. FIxing them? not
my job.

The Makefile has been rewritten to be aware of new changes. In the long
run webpack would be the way to go still.

We try to use the "sensible" build when possible, handling all the old
try/catch magic in catsrc. This mostly works, except for a problem in
the parser that appears to be also present in my previous version: a
huge object tries to reference things that don't exist.

[The site is unchanged for now to avoid breaking any new things.
Somebody added a // comment to CSS which is invalid, so expect it to not
work. I did not break it.]

The eslint rules are enabled. They don't really hit any package problems
any more, so I figure it's time to turn them on. I added an rc for the
tests so every complaint left is a true positive now.

The Makefile has been rewritten to be aware of new changes. In the long
run webpack would be the way to go still.
@Artoria2e5
Copy link
Author

And who came up with the idea of committing built stuff to master anyways?

@antfu
Copy link
Member

antfu commented Dec 30, 2019

Hi @Artoria2e5 Please make sure all the tests pass. Thanks!

@Artoria2e5
Copy link
Author

The failures are mainly due to new eslint rules being enabled. Confirm that you want these things fixed. (No false positives, so I guess it should be a go.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants