Generics AppType refactoring #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 86.41% 87.03% +0.61%
==========================================
Files 76 79 +3
Lines 2952 3092 +140
==========================================
+ Hits 2551 2691 +140
Misses 401 401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elitonzky
force-pushed
the
feature/generics-refactoring
branch
2 times, most recently
from
a043c44 to
1b7a78e
Compare
| @@ -6,19 +6,32 @@ | |||
| from marketplace.core.types.channels.generic.views import GetIcons | |||
| from marketplace.core.types.channels.generic.views import GenericAppTypes | |||
|
|
|||
| from marketplace.core.types.externals.generic.views import ( | |||
There was a problem hiding this comment.
The main idea of this listing of urls is that it was generic, that way you are creating a dependency with a specific apptype, the generic-external.
The question is: if a new generic apptype comes up, will you need to implement new urls for it in this file? this deviates a little from the principles of Integrations!
I suggest that you create a way to create urls within the type itself, so that the types would be in fact generic.
| else: | ||
| raise serializers.ValidationError("external_code not be empty.") | ||
|
|
||
| response = self.type_class.list(FlowsClient(), flows_type_code=external_code) |
There was a problem hiding this comment.
Nice implementation of dependency inversion! 👏
elitonzky
force-pushed
the
feature/generics-refactoring
branch
2 times, most recently
from
b0985f1 to
b9e2776
Compare
elitonzky
force-pushed
the
feature/generics-refactoring
branch
from
b9e2776 to
2f1fad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.